About Store Forum Documentation Contact



Post Reply 
Bugs in EditorInterface::worldObjGetDesc/Data
Author Message
Fex Offline
Gold Supporter

Post: #1
Bugs in EditorInterface::worldObjGetDesc/Data
EditorInterface::worldObjGetDesc and EditorInterface::worldObjGetData

Do not get sent by the client if the C CMemPtr<UID> &world_obj_instance_ids=null parameter is null.

Therefore I would recommend removing the default "null"s here:

https://github.com/Esenthel/EsenthelEngi...ace.h#L341

To force users to pass in a world_obj_instance_ids.

Secondly, the client does not send the request if world_obj_instance_ids elms == 0;

https://github.com/Esenthel/EsenthelEngi...e.cpp#L905
https://github.com/Esenthel/EsenthelEngi...e.cpp#L922

I believe at both of the locations:
Code:
&& world_obj_instance_ids.elms()
should be removed. Also in the fail return as well.

The Editor source code here:
https://github.com/Esenthel/EsenthelEngi...r.cpp#L666
https://github.com/Esenthel/EsenthelEngi...r.cpp#L738

Makes it clear that the intent is that world_obj_instance_ids.elms() == 0 should be able to be sent from the client, but that is not the case, it does not get sent, and the return value of the functions are "true" even when the request packet is not sent.

Edit:

Also not really a bug but limit_obj_ids is defined in case Edit.EI_GET_WORLD_OBJ_FULL but never used:

https://github.com/Esenthel/EsenthelEngi...r.cpp#L738
(This post was last modified: 11-13-2022 06:58 PM by Fex.)
11-13-2022 06:49 PM
Find all posts by this user Quote this message in a reply
Esenthel Offline
Administrator

Post: #2
RE: Bugs in EditorInterface::worldObjGetDesc/Data
Thank you very much,
I've applied changes:
https://github.com/Esenthel/EsenthelEngi...59bdabe3b4
11-14-2022 10:02 AM
Find all posts by this user Quote this message in a reply
Post Reply