Rubeus
Member
|
Engine Source Etiquette
I'm curious as to what kind of rules we should follow as far as the engine source. For example, if someone is asking a question about 'behind the scenes' functionality(eg. http://www.esenthel.com/community/showth...p?tid=7535 ), is it ok to explain(but not show code)? What about discussing the source? (I remember there used to be a locked section years back for 1.0 source purchasers.)
I've been reading the code, but I have to wait to get home to use VS2008 so I can compile it. I'm fairly well impressed so far.
|
|
04-12-2014 11:40 PM |
|
Esenthel
Administrator
|
RE: Engine Source Etiquette
Hi,
Thank you for your opinion.
1. I'm completely fine with explaining something to others as long as you don't expose any source code.
2. About discussing the source - in the next few days I'll try to make a new private section for Source License owners along with new Forum User Titles.
|
|
04-12-2014 11:44 PM |
|
Esenthel
Administrator
|
RE: Engine Source Etiquette
|
|
04-13-2014 02:15 AM |
|
Esenthel
Administrator
|
RE: Engine Source Etiquette
|
|
04-13-2014 04:32 AM |
|
Rubeus
Member
|
RE: Engine Source Etiquette
Excellent. If you wouldn't mind, could you also post guidelines for submitting code? Both for how the code itself is formatted - do you want us to comment our names around the sections that we modified? - as well as the procedure for uploading changes. Do we need to notify you somehow of changes we made so you can add the changes to the version history forum?
(This post was last modified: 04-13-2014 06:25 PM by Rubeus.)
|
|
04-13-2014 06:24 PM |
|
Esenthel
Administrator
|
RE: Engine Source Etiquette
Hi,
I'm not too experienced with GitHub, but from what I know, you select the Fork option there, then apply your custom changes to your own Fork, then you can select "pull request" or something like that.
At this point I don't know if GitHub will notify me of a pull request, so you can PM me.
Once I verify the changes you've made, I can consider merging them into the main branch.
As for formatting, please stick to the formatting that is used across the entire engine source.
|
|
04-13-2014 10:13 PM |
|